Skip to content

Add support for Visual Studio 2026#2509

Open
hwangsihu wants to merge 2 commits into
DOCGroup:masterfrom
hwangsihu:master
Open

Add support for Visual Studio 2026#2509
hwangsihu wants to merge 2 commits into
DOCGroup:masterfrom
hwangsihu:master

Conversation

@hwangsihu
Copy link
Copy Markdown

@hwangsihu hwangsihu commented Mar 4, 2026 •
edited by coderabbitai Bot
Loading

Summary by CodeRabbit

  • New Features

    • Official support added for Visual Studio 2026 across builds and project templates, including language-standard alignment.

  • Chores

    • Windows CI expanded to include Visual Studio 2026 build configurations.
    • New configuration fragments and project templates added to enable VS2026 builds and related feature flags.

  • Documentation

    • Release notes updated to announce Visual Studio 2026 support.

Review Change Stack

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 4, 2026 •
edited
Loading

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

Walkthrough

Added Visual Studio 2026 support across CI, build tooling, and ACE configuration: new CI matrix entries, new MSVC 14.5 config header and gating, VS2026 MakeProjectCreator feature and nmake files, and a NEWS entry documenting the addition.

Changes

VS2026 support (CI, MSVC config, MakeProjectCreator, docs)

Layer / File(s) Summary
CI matrix entries
.github/workflows/cmake.yml, .github/workflows/windows.yml		 Add VS2026 entries to the GitHub Actions matrices: new vs2026 toolset using windows-2025-vs2026 runner and x64 Debug/Release variants (vcpkg settings preserved).
MSVC config header and gating
ACE/ace/config-win32-msvc-145.h, ACE/ace/config-win32-msvc.h		 Introduce config-win32-msvc-145.h (defines ACE_WIN32_VC145) and update _MSC_VER checks to include the new header when _MSC_VER >= 1950, falling back to the existing 143 header otherwise.
MakeProjectCreator feature file
ACE/bin/MakeProjectCreator/config/vs2026.features		 Add VS2026 feature flags: ssl=0, qos=1, rwho=0, sctp=0.
MakeProjectCreator nmake config
ACE/bin/MakeProjectCreator/config/vs2026nmake.mpb		 Add nmake-specific configuration: remove /Wp64 and /Gm, and suppress VC warnings 4456/4458/4459 for the nmake backend; enable C++17 language standard for vs2026.
Release notes
ACE/NEWS		 Add NEWS bullet announcing Visual Studio 2026 support.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested reviewers

  • jwillemsen

Poem

🐰 Hop, a new toolset leaps in view,
VS2026, shiny and new.
Workflows updated, headers align,
Feature files tucked in a neat design.
I nibble the build and joyfully chew.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Add support for Visual Studio 2026' accurately and concisely summarizes the main change across all modified files—adding comprehensive VS 2026 configuration to CI workflows, header files, and build system.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@jwillemsen
Copy link
Copy Markdown
Member

jwillemsen commented Mar 4, 2026

Have you done a full build with tests? On github CI we only compile a small part of the code and don't run tests at all.

@hwangsihu
Copy link
Copy Markdown
Author

hwangsihu commented Mar 4, 2026

Hi.

Sorry, is there any documentation on building ACE and TAO? I can't find it.

@jwillemsen
Copy link
Copy Markdown
Member

jwillemsen commented Mar 4, 2026

See https://htmlpreview.github.io/?https://github.com/DOCGroup/ACE_TAO/blob/master/ACE/ACE-INSTALL.html, at the bottom there are some instructions to build from git. Without a full build/test I think it is too early to say Visual Studio 2026 is supported, maybe it compiles the core, but the real test is a full build/test and also look at warnings and runtime test results.

@hwangsihu hwangsihu marked this pull request as draft March 4, 2026 10:37
@jwillemsen
Copy link
Copy Markdown
Member

jwillemsen commented Mar 4, 2026

Depends on DOCGroup/MPC#242

@hwangsihu
Copy link
Copy Markdown
Author

hwangsihu commented Mar 4, 2026

Okay, Seems good.

@hwangsihu hwangsihu marked this pull request as ready for review March 4, 2026 15:24
jwillemsen
jwillemsen reviewed Mar 5, 2026
View reviewed changes
Comment thread ACE/bin/MakeProjectCreator/config/acedefaults.mpb
jwillemsen
jwillemsen reviewed Mar 5, 2026
View reviewed changes
Comment thread ACE/bin/MakeProjectCreator/config/vs2026nmake.mpb Outdated
jwillemsen
jwillemsen reviewed Mar 6, 2026
View reviewed changes
Comment thread ACE/tests/OneByteFile Outdated
@codacy-production
Copy link
Copy Markdown

codacy-production Bot commented May 13, 2026 •
edited
Loading

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity

Metric Results
Complexity 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@hwangsihu hwangsihu force-pushed the master branch 2 times, most recently from eaa7ca1 to 6ff561a Compare May 17, 2026 12:25
jwillemsen
jwillemsen reviewed May 18, 2026
View reviewed changes
Comment thread ACE/NEWS Outdated
@jwillemsen
Copy link
Copy Markdown
Member

jwillemsen commented May 19, 2026

Please don't force push a branch, makes it more complex and time consuming to review

jwillemsen
jwillemsen reviewed May 19, 2026
View reviewed changes
Comment thread ACE/bin/MakeProjectCreator/config/vs2026nmake.mpb Outdated
jwillemsen
jwillemsen reviewed May 19, 2026
View reviewed changes
Comment thread ACE/bin/MakeProjectCreator/config/acedefaults.mpb Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jwillemsen jwillemsen jwillemsen left review comments

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hwangsihu @jwillemsen